Query: Enable materialzing collections of arbirtary shape in projection #16312
+549
−317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/EFCore.Relational/Query/Pipeline/CollectionInitializingExperssion.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Query/Pipeline/RelationalProjectionBindingExpressionVisitor.cs
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Jun 28, 2019
Part of #15611 Will send out separate PR to enable tests and fix edge case bugs This PR - Split out collection initialization/population for include to separate method due to type constraints - Swallow materialize collection navigation/ToList in projection. Rest of unknown methods, we will fall into client eval - Changes SqlTranslator to try translate & lift subquery always, allowing it to translate non Queryable defined but translatable methods - Make identifiers nullable always to identify null keys & no correlation
smitpatel
force-pushed
the
smit/collections_take3
branch
from
9515b00
to
a8398c3
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15611
Will send out separate PR to enable tests and fix edge case bugs
This PR